Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(TypeHandlerLibrary): fix error-during-error-logging in GenericMap #5048

Merged
merged 1 commit into from
Jun 14, 2022
Merged

fix(TypeHandlerLibrary): fix error-during-error-logging in GenericMap #5048

merged 1 commit into from
Jun 14, 2022

Conversation

keturn
Copy link
Member

@keturn keturn commented Jun 14, 2022 •
edited
Loading

Fixes a case in GenericMapTypeHandler where it's trying to tell you about some error it's found and uses data.getAsString() to describe it, but that results in another error when data isn't String.

@keturn keturn added Type: Bug Issues reporting and PRs fixing problems Topic: Stabilization Requests, Issues and Changes related to improving stablity and reducing flakyness Size: S Small effort likely only affecting a single area and requiring little to no research labels Jun 14, 2022
@keturn keturn marked this pull request as ready for review June 14, 2022 22:23
@keturn keturn requested review from skaldarnar, eviltak and DarkWeird and removed request for eviltak June 14, 2022 22:24
eviltak
eviltak approved these changes Jun 14, 2022
View reviewed changes
Copy link
Member

@eviltak eviltak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Doesn't look like there are any breaking functional changes, but if there are they should hopefully be caught by unit tests.

@keturn
Copy link
Member Author

keturn commented Jun 14, 2022

yep, the changes should just be to the error-handling branch. Thanks!

@keturn keturn merged commit fbc40c3 into develop Jun 14, 2022
@keturn keturn deleted the fix/thlErrorReporting branch June 14, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eviltak eviltak eviltak approved these changes

@skaldarnar skaldarnar Awaiting requested review from skaldarnar

@DarkWeird DarkWeird Awaiting requested review from DarkWeird

Assignees
No one assigned
Labels
Size: S Small effort likely only affecting a single area and requiring little to no research Topic: Stabilization Requests, Issues and Changes related to improving stablity and reducing flakyness Type: Bug Issues reporting and PRs fixing problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keturn @eviltak